Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: deprecate transformer tutorial #2910

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

loganthomas
Copy link
Contributor

@loganthomas loganthomas commented Jun 7, 2024

Fixes #2895

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @sekyondaMeta @svekars @kit1980 @brycebortree

Copy link

pytorch-bot bot commented Jun 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2910

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 88956da with merge base e64dc22 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @loganthomas!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@loganthomas
Copy link
Contributor Author

@svekars
It looks like there is another advanced tutorial that has the same issue:

Shall I deprecate this one as well in this PR? Or, submit another issue/PR to resolve that one?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars
Copy link
Contributor

svekars commented Jun 7, 2024

@svekars It looks like there is another advanced tutorial that has the same issue:

Shall I deprecate this one as well in this PR? Or, submit another issue/PR to resolve that one?

Can you please create a separate task for this work? We will need to work with the owner of this tutorial to understand if there is any other solutions they want to propose.

@loganthomas
Copy link
Contributor Author

@pytorchbot merge

@loganthomas
Copy link
Contributor Author

loganthomas commented Jun 8, 2024

@svekars It looks like there is another advanced tutorial that has the same issue:

Shall I deprecate this one as well in this PR? Or, submit another issue/PR to resolve that one?

Can you please create a separate task for this work? We will need to work with the owner of this tutorial to understand if there is any other solutions they want to propose.

See #2916

@loganthomas
Copy link
Contributor Author

@pytorchbot merge

@svekars svekars merged commit 48905cf into pytorch:main Jun 10, 2024
18 checks passed
@loganthomas loganthomas deleted the 2895-dep-transformer_tutorial branch June 10, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Dependency Issue in Language Modeling with nn.Transformer and torchtext Tutorial
3 participants