Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added USB tutorial script #2676

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Added USB tutorial script #2676

merged 7 commits into from
Dec 7, 2023

Conversation

Hhhhhhao
Copy link
Contributor

@Hhhhhhao Hhhhhhao commented Nov 12, 2023

Fixes #2670

Description

Added USB tutorial script

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @datumbox @nairbv @fmassa @NicolasHug @YosuaMichael @sekyondaMeta @svekars @carljparker @kit1980 @subramen

Copy link

pytorch-bot bot commented Nov 12, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2676

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2151259 with merge base 37462ab (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @Hhhhhhao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Hhhhhhao
Copy link
Contributor Author

I fixed some typos from the grammar check.
But some other words are not typos but algorithm names.

@carljparker
Copy link
Contributor

Add @NicolasHug as reviewer, in addition to @subramen

Copy link
Contributor

@subramen subramen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the suggestions are addressed, good to go from me! Thanks @Hhhhhhao for submitting this tutorial :)

@@ -0,0 +1,223 @@
"""
Semi-Supervised Learning using USB built upon Pytorch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all occurrences of "Pytorch" with "PyTorch"

Introduction
------------

USB is a semi-supervised learning framework built upon Pytorch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a few sentences about how USB uses PyTorch under the hood. This will increase confidence for PyTorch users to try out USB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

I have fixed the corresponding places.

Copy link
Contributor

@subramen subramen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include this tutorial in the index.rst file

Example: 16e4f2a#diff-54a294a5d016e1a8e98bc95668ed84a99a9edd5c10394d9a2b1ee848006e98a7

@Hhhhhhao
Copy link
Contributor Author

Hhhhhhao commented Dec 5, 2023

Include this tutorial in the index.rst file

Example: 16e4f2a#diff-54a294a5d016e1a8e98bc95668ed84a99a9edd5c10394d9a2b1ee848006e98a7

Added USB to index file

@carljparker carljparker merged commit 17e81c1 into pytorch:main Dec 7, 2023
19 of 20 checks passed
@svekars
Copy link
Contributor

svekars commented Dec 9, 2023

Execution time of this tutorial is 142 minutes - https://pytorch.org/tutorials/advanced/usb_semisup_learn.html.

@svekars svekars mentioned this pull request Dec 12, 2023
@Hhhhhhao
Copy link
Contributor Author

Hi, I found the image is not compiled well. Also the reference is messed up. Can I make a few changes regarding these issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Tutorial of USB for Semi-Supervised Learning
5 participants