Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to last episode #2656

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

alperenunlu
Copy link
Contributor

@alperenunlu alperenunlu commented Nov 6, 2023

Fixes #2651

Description

Improved the episode functionality by ensuring that episodes are logged properly, preventing unnecessary episode runs without logging.

Checklist

  • The issue that is being fixed is referred in the description
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @vmoens @nairbv @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

Copy link

pytorch-bot bot commented Nov 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2656

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6147dd2 with merge base 4eb4483 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added bug rl Issues related to reinforcement learning tutorial, DQN, and so on docathon-h2-2023 and removed cla signed labels Nov 6, 2023
@svekars svekars requested a review from vmoens November 6, 2023 23:27
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svekars svekars merged commit 105e952 into pytorch:main Nov 7, 2023
24 checks passed
@alperenunlu alperenunlu deleted the mariorl-logging-fix branch November 7, 2023 17:41
@svekars svekars added the easy label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cla signed docathon-h2-2023 easy rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - MarioRL Not Logging Last Episode
4 participants