Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Port TorchRL Pendulum tutorial from pytorch.org/rl to pytorch.org/tutorials #2653

Merged
merged 34 commits into from
Nov 9, 2023
Merged

Fix - Port TorchRL Pendulum tutorial from pytorch.org/rl to pytorch.org/tutorials #2653

merged 34 commits into from
Nov 9, 2023

Conversation

krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Nov 6, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2653

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6c025c6 with merge base a668406 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added rl Issues related to reinforcement learning tutorial, DQN, and so on medium docathon-h2-2023 and removed cla signed labels Nov 6, 2023
@krishnakalyan3
Copy link
Contributor Author

Quick question @svekars, Can you please let me know where the static images need to be placed?.

https://github.com/pytorch/rl/blob/main/tutorials/sphinx-tutorials/pendulum.py#L17C38-L17C38

@svekars
Copy link
Contributor

svekars commented Nov 6, 2023

You can put under _static/img/.

svekars
svekars reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Make sure that the formatting looks good in the PR preview. Also, please fix the spellcheck.

beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
beginner_source/pendulum.py Outdated Show resolved Hide resolved
@svekars svekars requested a review from vmoens November 6, 2023 17:11
krishnakalyan3 and others added 7 commits November 6, 2023 18:43
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
ed84726 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
245512f 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
a836e9b 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
84612a9 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
c471ad1 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
456ac8f 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@krishnakalyan3 @svekars
Update beginner_source/pendulum.py
8abdf16 
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@svekars
Copy link
Contributor

svekars commented Nov 7, 2023

please maker sure to fix the spellcheck

vmoens
vmoens approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for doing this!

@svekars
Copy link
Contributor

svekars commented Nov 8, 2023

Still need to fix spellcheck and resolve the merge conflict. Otherwise, looks good.

svekars
svekars reviewed Nov 8, 2023
View reviewed changes
advanced_source/pendulum.py Outdated Show resolved Hide resolved
svekars
svekars reviewed Nov 8, 2023
View reviewed changes
advanced_source/pendulum.py Outdated Show resolved Hide resolved
@vmoens vmoens mentioned this pull request Nov 9, 2023
Merged
@svekars svekars merged commit 16e4f2a into pytorch:main Nov 9, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars left review comments

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
cla signed docathon-h2-2023 medium rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Port TorchRL Pendulum tutorial from pytorch.org/rl to pytorch.org/tutorials
4 participants
@krishnakalyan3 @svekars @vmoens @facebook-github-bot