Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update super_resolution_with_onnxruntime.py #2647

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Conversation

ahoblitz
Copy link
Contributor

@ahoblitz ahoblitz commented Nov 4, 2023

add install for onnx

Fixes #2646

Description

Install ONNX to avoid dependency issues

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @BowenBao @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

Copy link

pytorch-bot bot commented Nov 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2647

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f93cc94 with merge base e7563f6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars added onnx Issues relating to ONNX docathon-h2-2023 easy labels Nov 4, 2023
@svekars
Copy link
Contributor

svekars commented Nov 4, 2023

@thiagocrepaldi does this look good to you?

@malfet malfet merged commit 77aec05 into pytorch:main Nov 5, 2023
18 checks passed
@github-actions github-actions bot added bug and removed cla signed onnx Issues relating to ONNX labels Nov 5, 2023
Copy link
Contributor

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is fine to install onnx along with onnxruntime here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - super_resolution_with_onnxruntime missing install for onnx
5 participants