Update parametrizations.py #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For PyTorch 2, torch.solve => torch.linalg.solve
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2642
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 61ccafe with merge base 3ac15b1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
added
the
core
svekars
approved these changes
Nov 3, 2023
malfet
approved these changes
Nov 3, 2023
malfet
requested changes
Nov 3, 2023
svekars
reviewed
Nov 3, 2023
malfet
reviewed
Nov 3, 2023
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
malfet
approved these changes
Nov 4, 2023
malfet
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Nov 9, 2023
Add torch.solve as a removed function (I somehow missed it before and noticed after pytorch/tutorials#2642). Also added a mechanism to show reference links in the error messages.
kit1980
added a commit
to pytorch-labs/torchfix
that referenced
this pull request
Nov 23, 2023
Add torch.solve as a removed function (I somehow missed it before and noticed after pytorch/tutorials#2642). Also added a mechanism to show reference links in the error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PyTorch 2, torch.solve => torch.linalg.solve
Fixes #2641
Description
Code like
def forward(self, X):# (I + X)(I - X)^{-1}return torch.solve(self.Id + X, self.Id - X).solutionresults in
RuntimeError: This function was deprecated since version 1.9 and is now removed. torch.solve is deprecated in favor of torch.linalg.solve. torch.linalg.solve has its arguments reversed and does not return the LU factorization.Update to use
pytorch.linalg.solveChecklist
cc @albanD @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen