Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mario_rl_tutorial.py #2640

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Update mario_rl_tutorial.py #2640

merged 2 commits into from
Nov 3, 2023

Conversation

ahoblitz
Copy link
Contributor

@ahoblitz ahoblitz commented Nov 3, 2023

This should fix #2627

Fixes #2627

Description

Click on Run in Google Collab button and Run all cells

It will fail while trying to import tensordict:


---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
[<ipython-input-3-8f359b2f0b63>](https://localhost:8080/#) in <cell line: 21>()
     19 import gym_super_mario_bros
     20 
---> 21 from tensordict import TensorDict
     22 from torchrl.data import TensorDictReplayBuffer, LazyMemmapStorage

ModuleNotFoundError: No module named 'tensordict'

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @vmoens @nairbv @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

Copy link

pytorch-bot bot commented Nov 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2640

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a84bf3d with merge base 586b3da (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars requested a review from malfet November 3, 2023 18:37
@svekars svekars added the rl Issues related to reinforcement learning tutorial, DQN, and so on label Nov 3, 2023
@github-actions github-actions bot added bug and removed cla signed rl Issues related to reinforcement learning tutorial, DQN, and so on labels Nov 3, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@svekars svekars merged commit 3ac15b1 into pytorch:main Nov 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - MarioRL tutorial does not work on the collab
4 participants