Remove broken links in tuning guide #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of "for more details" links to external sites are no longer finding details. Better to remove them. Signed-off-by: markstur <mark.sturdevant@ibm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2636
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a07d27 with merge base 5d69b49 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@derrickmo it's okay but you don't really need to assign the pull request to yourself. Just the issues. |
|
Got it. Thanks for the note. I will look into other issues 👍 |
|
looks good in the CI built preview https://docs-preview.pytorch.org/pytorch/tutorials/2636/recipes/recipes/tuning_guide.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of "for more details" links to external sites are no longer finding details. Better to remove them.
Fixes #2629
Description
The current suggestion was to remove the links. It is better to not suggest more details when the links destinations move.
Checklist
cc @svekars @carljparker @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @ZailiWang @ZhaoqiongZ @leslie-fang-intel @Xia-Weiwen @sekahler2 @CaoE @zhuhaozhe @Valentine233 @sekyondaMeta @NicolasHug @kit1980 @subramen