Sequence to sequence encoder-decoder attention #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2468
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3dba0f5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Nayef211
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks for addressing the comments on the earlier PR @JoseLuisC99. Approved! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121
Description
Redefines the attention mechanism and decoder network from the tutorial NLP From Scratch: Translation with a Sequence to Sequence Network and Attention.
Due to merge conflicts, I had to close PR #2427, however I addressed the feedback received in my last PR.