Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced use of copy.deepcopy() #2432

Closed
wants to merge 3 commits into from

Conversation

JoseLuisC99
Copy link
Contributor

Fixes #2331

Description

Replaces use of copy.deepcopy() in Convolution/Batch Norm Fuser tutorial.

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit f1bf472
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6482566b6c72840008f0efca
😎 Deploy Preview https://deploy-preview-2432--pytorch-tutorials-preview.netlify.app/intermediate/fx_conv_bn_fuser
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels Jun 6, 2023
@svekars svekars requested a review from kit1980 June 6, 2023 16:11
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2432

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f1bf472:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@kit1980 kit1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense to me.
torch.load accepts a file, not a dict.

Please verify the code before submitting.

@kit1980
Copy link
Member

kit1980 commented Jun 9, 2023

And looking closer, I think the deepcopy is fine there, no need to change really.

@kit1980 kit1980 closed this Jun 9, 2023
@JoseLuisC99
Copy link
Contributor Author

I'm so sorry, it's more correct to use load_state_dict instead of load as mentioned in Deep copying PyTorch modules.

@JoseLuisC99 JoseLuisC99 deleted the replace_deepcopy branch June 9, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed docathon-h1-2023 A label for the docathon in H1 2023 easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tutorial to avoid use of copy.deepcopy()- Convolution/Batch Norm Fuser in FX
3 participants