Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the random seed for reproducibility of the output #2428

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Set the random seed for reproducibility of the output #2428

merged 2 commits into from
Jun 8, 2023

Conversation

bjhargrave
Copy link
Contributor

@bjhargrave bjhargrave commented Jun 5, 2023 •
edited by svekars
Loading

Fixes #1449
We also fix the code to use the scripted_cell just created.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @eellison @suo @gmagogsfm @jamesr66a

@bjhargrave
Set the random seed for reproducibility of the output
6b1547a 
We also fix the code to use the scripted_cell just created.

Fixes pytorch#1449

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@netlify
Copy link

netlify bot commented Jun 5, 2023 •
edited
Loading

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 660d36e
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/648201df3a7d760009db573d
😎 Deploy Preview https://deploy-preview-2428--pytorch-tutorials-preview.netlify.app/beginner/intro_to_torchscript_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added torchscript Issues relating to TorchScript tutorials docathon-h1-2023 A label for the docathon in H1 2023 medium and removed cla signed labels Jun 5, 2023
@sekyondaMeta sekyondaMeta requested a review from kit1980 June 7, 2023 17:07
NicolasHug
NicolasHug approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjhargrave

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2428

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars merged commit 1fe4025 into pytorch:main Jun 8, 2023
svekars pushed a commit that referenced this pull request Jun 9, 2023
@bjhargrave
Set the random seed for reproducibility of the output (#2428)
f23f060 
We also fix the code to use the scripted_cell just created.
Fixes #1449
Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@kit1980 kit1980 Awaiting requested review from kit1980

Assignees
No one assigned
Labels
docathon-h1-2023 A label for the docathon in H1 2023 medium torchscript Issues relating to TorchScript tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "traced_cell.code" output is wrong and misleading!!
4 participants
@bjhargrave @NicolasHug @svekars @facebook-github-bot