Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change paper reference to a paper matching the model used #2424

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

bjhargrave
Copy link
Contributor

@bjhargrave bjhargrave commented Jun 5, 2023

Fixes #1642

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @pytorch/team-text-core @Nayef211

@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit d317551
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6481e7aaaf045a0008291ad1
😎 Deploy Preview https://deploy-preview-2424--pytorch-tutorials-preview.netlify.app/intermediate/seq2seq_translation_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Fixes pytorch#1642

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2424

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d317551:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@sekyondaMeta sekyondaMeta merged commit 3b6d83b into pytorch:main Jun 8, 2023
14 checks passed
@bjhargrave bjhargrave deleted the issues/1642 branch June 8, 2023 15:59
svekars pushed a commit that referenced this pull request Jun 9, 2023
Fixes #1642

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Co-authored-by: sekyondaMeta <127536312+sekyondaMeta@users.noreply.github.com>
@svekars svekars added the easy label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attention decoder in seq2seq model different from the one on paper
4 participants