Remove improper src_mask from encoder tutorial #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tutorial is using a transformer encoder and the mask used was for masking a decoder which is not part of the tutorial. The mask is removed. Some variable names are changed to better reflect the purpose of the variable. Also, some unused imports are removed. Fixes pytorch#1877 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
module: torchtext
docathon-h1-2023
Nayef211
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
LGTM. Thanks for helping improve PyTorch tutorials @bjhargrave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1877
The tutorial is using a transformer encoder and the mask used was for masking a decoder which is not part of the tutorial.
The mask is removed. Some variable names are changed to better reflect the purpose of the variable. Also, some unused imports are removed.
Checklist
cc @pytorch/team-text-core @Nayef211