Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve data_loading_tutorial.py with use of enumerate #2407

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Improve data_loading_tutorial.py with use of enumerate #2407

merged 3 commits into from
Jun 2, 2023

Conversation

noqqaqq
Copy link
Contributor

@noqqaqq noqqaqq commented Jun 2, 2023

Fixes #995

Description

Replace iteration over range of indexes with enumerate over dataset in data_loading_tutorial.py

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@github-actions github-actions bot added data loading Issues relating to the data loading tutorial docathon-h1-2023 A label for the docathon in H1 2023 medium and removed cla signed labels Jun 2, 2023
@netlify
Copy link

netlify bot commented Jun 2, 2023 •
edited
Loading

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit d5d3dec
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/647a0e7238d8ec0008b64d2a
😎 Deploy Preview https://deploy-preview-2407--pytorch-tutorials-preview.netlify.app/beginner/data_loading_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

NicolasHug
NicolasHug approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noqqaqq

@NicolasHug NicolasHug mentioned this pull request Jun 2, 2023
Closed
@svekars svekars merged commit fd9a6a7 into pytorch:main Jun 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
data loading Issues relating to the data loading tutorial docathon-h1-2023 A label for the docathon in H1 2023 medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data_loading_tutorial.py iterators
4 participants
@noqqaqq @NicolasHug @svekars @facebook-github-bot