Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change formatting of code blocks in Tensorboard profiler tutorial #2398

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

kiersten-stokes
Copy link
Contributor

@kiersten-stokes kiersten-stokes commented Jun 1, 2023

Fixes #1901

Description

After these changes, the HTML is being rendered as it was before (expected behavior), but the corresponding code blocks in the Colab notebook will be rendered properly.

Before (following link from tutorial HTML):
Screenshot 2023-06-01 at 11 23 59 AM

After (rendered in VSCode):
Screenshot 2023-06-01 at 11 24 27 AM

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnessessary issues are included into this pull request.

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit d38aa4c
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6478c677d2555800079dbb9e
😎 Deploy Preview https://deploy-preview-2398--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added Profiler Issues relating to profiler tutorials build issue Issues relating to the tutorials build colab docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels Jun 1, 2023
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kiersten-stokes!

@svekars svekars merged commit 4cd44ae into pytorch:main Jun 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build issue Issues relating to the tutorials build cla signed colab docathon-h1-2023 A label for the docathon in H1 2023 easy Profiler Issues relating to profiler tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: tensorboard profiler tutorial doesn't render properly
3 participants