Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change batchify desc to remove ambiguity #2383

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

QasimKhan5x
Copy link
Contributor

@QasimKhan5x QasimKhan5x commented Jun 1, 2023

Fixes #1037

Description

Changed the text,

we would divide the alphabet into 4 sequences of length 6

to

we would divide the alphabet into sequences of length 6, resulting in 4 such sequences

With this, the reader knows that a tensor of shape (seq_length, batch_size) is being created, which is consistent with the shape of the tensor returned by the batchify function

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 87bdc84
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6478c9b12ad3630007f5f22b
😎 Deploy Preview https://deploy-preview-2383--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added Text Issues relating to text tutorials docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels Jun 1, 2023
@carljparker carljparker self-requested a review June 1, 2023 16:37
Copy link
Contributor

@carljparker carljparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, Qasim. Thanks for your help!

@carljparker carljparker merged commit d9fd5ba into pytorch:main Jun 1, 2023
7 checks passed
@QasimKhan5x QasimKhan5x deleted the patch-2 branch June 1, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2023 A label for the docathon in H1 2023 easy Text Issues relating to text tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguity in transformer_tutorial.py
3 participants