Fix the loss initialization in intermediate_source/char_rnn_generation_tutorial.py #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
Text
akjalok
changed the title
NicolasHug
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
I'll approve, but as mentioned in the original issue #844 (comment) the current code is just fine. We don't need to initialize loss as a tensor.
svekars
reviewed
Jun 2, 2023
NicolasHug
reviewed
Jun 2, 2023
| @@ -278,7 +278,7 @@ def train(category_tensor, input_line_tensor, target_line_tensor): | |||
|
|
|||
| rnn.zero_grad() | |||
|
|
|||
| loss = 0 | |||
| loss = torch.tensor([0]) # in PyTorch 2.0 and later can be don't need to initialize as tensor, can be ``loss = 0`` | |||
There was a problem hiding this comment.
I believe this is true for any pytorch version, it's not related to 2.0
svekars
reviewed
Jun 2, 2023
NicolasHug
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844
Description
Changed the loss initialization from 0 to torch.Tensor([0]) in order to avoid confusion about the dtypes.
Checklist
cc @svekars @carljparker @kit1980