Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Err in char_rnn tutorial issue #2374

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

mikebrow
Copy link
Contributor

@mikebrow mikebrow commented May 31, 2023

Fixes #193

Description

  • Address issue described Err in char_rnn tutorial;
  • Also did a small amount of text only editing / cleanup missing links to related tutorials, correct a subtitle

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnessessary issues are included into this pull request.

@facebook-github-bot
Copy link
Contributor

Hi @mikebrow!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 6dbcc40
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6479164f21ed4d0008b33cae
😎 Deploy Preview https://deploy-preview-2374--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added docathon-h1-2023 A label for the docathon in H1 2023 medium labels Jun 1, 2023
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow
Copy link
Contributor Author

mikebrow commented Jun 1, 2023

rebased off main, odd the clone was only a couple hours old :)

I have internal administrator working on the fb cla, hopefully will check out correctly in the next hour..? Any chance this project will move to the pytorch lf/cla soon?

@svekars svekars requested a review from kit1980 June 1, 2023 15:20
Copy link
Contributor Author

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM on commit 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2023 A label for the docathon in H1 2023 medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Err in char_rnn tutorial
4 participants