Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update super_resolution_with_onnxruntime.py #2370

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

frasertajima
Copy link
Contributor

@frasertajima frasertajima commented May 31, 2023

Fix for #1781
"tutorials/advanced_source/super_resolution_with_onnxruntime.py is maybe outdated?"

References to requirements are out of date according to ONNX documentation (https://onnxruntime.ai/docs/reference/compatibility.html) which recommends the latest stable PyTorch version.

Rather than manually update the version number with the current stable version (e.g., 2.0.1), as long as ONNX maintains compatibility with the lastest stable version that reference should be sufficient and constantly up to date.

Fixes #1781

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnessessary issues are included into this pull request.

Fix for pytorch#1781
"tutorials/advanced_source/super_resolution_with_onnxruntime.py is maybe outdated?"

References to requirements are out of date according to ONNX documentation (https://onnxruntime.ai/docs/reference/compatibility.html) which recommends the latest stable PyTorch version. 

Rather than manually update the version number with the current stable version (e.g., 2.0.1), as long as ONNX maintains compatibility with the lastest stable version that reference should be sufficient and constantly up to date.
@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit b6f7df7
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6477b59bd9404400088234f0
😎 Deploy Preview https://deploy-preview-2370--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content A label for incorrect descriptions that needs to be updated docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels May 31, 2023
@svekars svekars merged commit d55a262 into pytorch:main May 31, 2023
7 checks passed
@frasertajima frasertajima deleted the patch-3 branch May 31, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content A label for incorrect descriptions that needs to be updated docathon-h1-2023 A label for the docathon in H1 2023 easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tutorials/advanced_source/super_resolution_with_onnxruntime.py is maybe outdated?
3 participants