Update nn_tutorial.py #2368
Merged
Update nn_tutorial.py #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to pytorch#1303 "add pyplot.show() in beginner tutorial." Comments to issue suggested manually commenting out pyplot.show for users not using colab. Instead, suggest change that imports colab and does nothing if user is running notebook on colab, otherwise it runs pyplot.show() (such as when running on a local machine). This way, manual editing of notebook is not required, colab users are undisturbed and local users get pyplot.show.
kit1980
reviewed
May 31, 2023
beginner_source/nn_tutorial.py
Outdated
| import google.colab | ||
| except ImportError: | ||
| pyplot.show() | ||
| pass |
There was a problem hiding this comment.
pass is not needed given pyplot.show(). Sorry!
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
intro
docathon-h1-2023
removed unnecessary "pass" (because pyplot.show() is present).
svekars
approved these changes
May 31, 2023
kit1980
approved these changes
May 31, 2023
svekars
reviewed
May 31, 2023
Fix for spellcheck
|
@frasertajima next time please use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #1303
"add pyplot.show() in beginner tutorial."
Comments to issue suggested manually commenting out pyplot.show for users not using colab.
Instead, suggest change that imports colab and does nothing if user is running notebook on colab, otherwise it runs pyplot.show() (such as when running on a local machine).
This way, manual editing of notebook is not required, colab users are undisturbed and local users get pyplot.show.
Fixes #1303
Description
Checklist
cc @suraj813