Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added matplotlib dependency to blitz tutorial #2366

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

BeniaminC
Copy link
Contributor

@BeniaminC BeniaminC commented May 31, 2023

Fixes #940

Description

Added matplotlib to the list of necessary packages for running the tutorials in "Deep Learning with Pytorch: A 60 Minute Blitz". The "Training a Classifier" tutorial requires matplotlib package for showing training images.
https://pytorch.org/tutorials/beginner/deep_learning_60min_blitz.html

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnessessary issues are included into this pull request.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 982d959
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6477f4f7ebeb660008876847
😎 Deploy Preview https://deploy-preview-2366--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels May 31, 2023
@BeniaminC BeniaminC changed the title Added matplotlib dependency to blitz tutorial. Added matplotlib dependency to blitz tutorial May 31, 2023
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you please unstage the changes to beginner_source/blitz/cifar10_tutorial.py

@carljparker carljparker self-assigned this May 31, 2023
Copy link
Contributor

@carljparker carljparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Beniamin.

@carljparker carljparker merged commit 0bee138 into pytorch:main Jun 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed docathon-h1-2023 A label for the docathon in H1 2023 easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib is used but not included in the 'Note'
4 participants