Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in the FX Graph Mode Quantization guide #2362

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

fabiogomez11c
Copy link
Contributor

@fabiogomez11c fabiogomez11c commented May 31, 2023

Fixes #2337

Description

Fix formatting in the tutorial: https://pytorch.org/tutorials/prototype/fx_graph_mode_quant_guide

Checklist

  • Remove the extraneous ###### lines
  • Remove numbering from the headings.
  • Add line breaks where needed
  • Make editorial changes as needed.

cc @svekars @carljparker

@facebook-github-bot
Copy link
Contributor

Hi @fabiogomez11c!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 18ba0e0
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6478bc8926f41a0008447bb9
😎 Deploy Preview https://deploy-preview-2362--pytorch-tutorials-preview.netlify.app/prototype/fx_graph_mode_quant_guide
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svekars
Copy link
Contributor

svekars commented May 31, 2023

Please sign the CLA so we can review your PR. Thank you for contributing to PyTorch!

@svekars svekars added the docathon-h1-2023 A label for the docathon in H1 2023 label May 31, 2023
@github-actions github-actions bot added bug website Issues related to website rendering easy labels May 31, 2023
@fabiogomez11c
Copy link
Contributor Author

Yes, I just did it, it says it could take up to an hour

@svekars
Copy link
Contributor

svekars commented May 31, 2023

Thanks so much for contributing. Makes sure the following is addressed:

  1. Please sign the CLA
  2. Provide a descriptive title in your PR - Like: Fix formatting in the FX Graph Mode Quantization guide

@svekars
Copy link
Contributor

svekars commented May 31, 2023

It looks like the code blocks are still not visible in the HTML. Compare the source:
source-gh
and the thml
html-page1

I think just adding a blank line between .. code:: and the code will solve the issue. Need to check for all code blocks.

Also, we can remove the numbering from the titles completely:

@fabiogomez11c
Copy link
Contributor Author

ok, I'll do it

@fabiogomez11c fabiogomez11c changed the title Fabio Fixed doc formatting for prototype May 31, 2023
@fabiogomez11c
Copy link
Contributor Author

@svekars I have a question, there are some TODOs inside this tutorial about adding some links, do you have in mind to add that in the future?

@fabiogomez11c fabiogomez11c changed the title Fixed doc formatting for prototype Fix formatting in the FX Graph Mode Quantization guide May 31, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much, Fabio!

@svekars svekars merged commit d368626 into pytorch:main Jun 1, 2023
7 checks passed
@fabiogomez11c fabiogomez11c deleted the fabio branch June 2, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docathon-h1-2023 A label for the docathon in H1 2023 easy website Issues related to website rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Fix formating
5 participants