[torchcodec] add get_frames_at method to SimpleVideoDecoder #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
Summary: Pull Request resolved: #80 This diff does several things: * Adds new method to `SimpleVideoDecoder`, with the signature: get_frames_at( self, start: int, stop: int, step: int = 1 ) -> FrameBatch * Adds the `FrameBatch` dataclass as a part of the public API. It has stacked version of the data, and pts and duration seconds are in N-dimensional tensors, where N is the size of the range. It is a sibling to the `Frame` dataclass. * Changes the return value of the core library function `get_frames_in_range()` as well as the underlying member function `VideoDecoder::getFramesInRange()` to return `Tuple[Tensor, Tensor, Tensor]`. The first value are the stacked frames, second is each pts in the range in a tensor, and third is each duration seconds in a tensor. This matches the new return type of `get_frame_at_index()`. * Updates our testing framework so that we can systematically associate pts and duration metadata with a particular test file. In this diff we are hardcoding the metadata into the testing utils. In the future, we should read it from a checked-in JSON file we generate with ffprobe. This diff is a partial implementation of the design in: https://fburl.com/gdoc/i6eqb634 Reviewed By: ahmadsharif1 Differential Revision: D59767617
|
This pull request was exported from Phabricator. Differential Revision: D59767617 |
|
This pull request has been merged in 13aadea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff does several things:
SimpleVideoDecoder, with the signature:get_frames_at(
self,
start: int,
stop: int,
step: int = 1,
) -> Frames
Framesdataclass as a part of the public API. It has stacked versions of all return values, and is a sibling to theFramedataclass.This diff is a partial implementation of the design in: https://fburl.com/gdoc/i6eqb634
Differential Revision: D59767617