Build wheel on gcc 9 (like pytorch) and add sanity check for wheel #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
changed the title
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug merged this pull request in cc0c71d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we build our wheel on gcc 9 (like torch) and adds a sanity check for wheel compatibility. This should prevent a common problem that @ahmadsharif1 and I have often observed when building locally. Please see comments in the code for a full explanation of the issue we're addressing.