Prevent building a wheel if BUILD_AGAINST_ALL_FFMPEG_FROM_S3 is not set #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…t_wheel_building_against_single_ffmpeg
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NicolasHug merged this pull request in e1e0352. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we build a wheel (typically in preparation of a new release), we should always build against our non-GPL FFmpeg libraries on S3, i.e.
BUILD_AGAINST_ALL_FFMPEG_FROM_S3should be set. This PR enforces that, and should prevent us from pushing a problematic wheel on PyPI.There might be good reasons to build a wheel against a specific installed version (e.g. maybe internally, or for debugging, or for an esoteric local setup). We still allow that if
I_SWEAR_I_KNOW_WHAT_IM_DOINGis set (happy to consider other names...)