Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch] Refactor/unify s3 lambda, improve s3 backfill script #5730

Merged
merged 4 commits into from
Oct 2, 2024
Merged

[ch] Refactor/unify s3 lambda, improve s3 backfill script #5730

merged 4 commits into from
Oct 2, 2024

Conversation

clee2000
Copy link
Contributor

Refactor the s3 replicator lambda to reduce dup code and have better error handling (upload to same database so we don't have to create a new one each time)

Tested via:

  • randomly selecting a key for merges, merge_bases, rerun_disabled_tests, external_contribution_stats and checking that it could be uploaded
  • backfilled inductor_torchao_perf_stats and torchbench_userbenchmark
  • rebackfilled queue_times_historical and removed dups
  • raise an exception to see if the error handler wrote to the database (it did)

Reused logic from lambda replicator in s3 backfill script

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 8:49pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2024
@clee2000 clee2000 marked this pull request as ready for review September 30, 2024 20:48
@clee2000 clee2000 requested a review from a team September 30, 2024 20:48
@clee2000 clee2000 changed the title [ch] Refactor/unify lambdas, improve s3 backfill script [ch] Refactor/unify s3 lambda, improve s3 backfill script Sep 30, 2024
huydhn
huydhn approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@clee2000 clee2000 merged commit aba7b57 into main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clee2000 @huydhn @facebook-github-bot