Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build package to build M1 wheels #5729

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Sep 30, 2024

This PR enable the build of M1 wheels to rely on python -m build instead of python setup.py. The default is still python setup.py.
This is the same as #5071 and #5076 that were landed for linux wheels.

We need this for torchcodec to support M1 wheels pytorch/torchcodec#230

CC @scotts @atalman

Copy link

vercel bot commented Sep 30, 2024

@NicolasHug is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 9aa668e into pytorch:main Oct 1, 2024
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants