Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch] Set up ingestion for benchmarks tables and aggregated_test_metrics #5720

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Sep 26, 2024

s3 tested by running locally and seeing if it got inserted
dynamo only checked python aws/lambda/clickhouse-replicator-dynamo/test_lambda_function.py to make sure other ingestions didn't break

Also small fix for external_contribution_stats error handler

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 4:31pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2024
@clee2000 clee2000 changed the title [ch] Set up ingestion for benchmarks tables [ch] Set up ingestion for benchmarks tables and aggregated_test_metrics Sep 26, 2024
@clee2000 clee2000 marked this pull request as ready for review September 26, 2024 21:27
@clee2000 clee2000 requested a review from a team September 26, 2024 21:28
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000 clee2000 merged commit 2f82232 into main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants