Add inputs.delocate-wheel to build_wheels_macos.yaml #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give clients a way to disable wheel delocation. This step is only run on macOS, so there's no equivalent change necessary in the linux or windows workflows.
|
@dbort is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
seemethere
approved these changes
Apr 19, 2024
seemethere
pushed a commit
that referenced
this pull request
Apr 19, 2024
) Cherry-pick #5107 into release/2.3 Give clients a way to disable wheel delocation. This step is only run on macOS, so there's no equivalent change necessary in the linux or windows workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give clients a way to disable wheel delocation.
This step is only run on macOS, so there's no equivalent change necessary in the linux or windows workflows.
https://github.com/pytorch/executorch/actions/runs/8759506663/job/24042678714?pr=3049 is an example run using a forked copy of this file (see pytorch/executorch@aca550b). It successfully skips the "Install delocate-wheel" and "Delocate wheel" steps.
While on the testing for this PR, both of those steps run by default: https://github.com/pytorch/test-infra/actions/runs/8759967852/job/24044074480?pr=5107