Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker image to docker release matrix #5081

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add docker image to docker release matrix #5081

merged 1 commit into from
Apr 10, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Apr 10, 2024 •
edited
Loading

Automate docker image validation. Add docker image to docker release matrix.

Test:

(.venv) [atalman@devvm1968.rva0 /data/users/atalman/test-infra/tools/scripts (generate_docker_matrix)]$ python generate_docker_release_matrix.py --channel release
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda11.8-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda11.8-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda12.1-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda12.1-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}]}
(.venv) [atalman@devvm1968.rva0 /data/users/atalman/test-infra/tools/scripts (generate_docker_matrix)]$ python generate_docker_release_matrix.py --channel release
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda11.8-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda11.8-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda12.1-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch:2.2.2-cuda12.1-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}]}
(.venv) [atalman@devvm1968.rva0 /data/users/atalman/test-infra/tools/scripts (generate_docker_matrix)]$ python generate_docker_release_matrix.py --channel test
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch-test:2.3.0-cuda11.8-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch-test:2.3.0-cuda11.8-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch-test:2.3.0-cuda12.1-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch-test:2.3.0-cuda12.1-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}]}
(.venv) [atalman@devvm1968.rva0 /data/users/atalman/test-infra/tools/scripts (generate_docker_matrix)]$ python generate_docker_release_matrix.py --channel nightly
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda11.8-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda11.8-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda12.1-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda12.1-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}]}
(.venv) [atalman@devvm1968.rva0 /data/users/atalman/test-infra/tools/scripts (generate_docker_matrix)]$ python generate_docker_release_matrix.py
{"include": [{"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda11.8-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "11.8", "cuda_full_version": "11.8.0", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda11.8-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "runtime", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda12.1-cudnn8-runtime", "platform": "linux/arm64,linux/amd64"}, {"cuda": "12.1", "cuda_full_version": "12.1.1", "cudnn_version": "8", "image_type": "devel", "docker": "ghcr.io/pytorch/pytorch-nightly:2.4.0.dev20240410-cuda12.1-cudnn8-devel", "platform": "linux/arm64,linux/amd64"}]}

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2024
joecummings
joecummings approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense - do you need to add a test though?

@atalman
Copy link
Contributor Author

atalman commented Apr 10, 2024

its ok, this will be called from docker-release validation worklfow here: pytorch/builder#1771

@atalman atalman merged commit 3259e39 into pytorch:main Apr 10, 2024
51 of 70 checks passed
@atalman atalman deleted the generate_docker_matrix branch April 10, 2024 15:35
@atalman atalman mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings joecummings approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @joecummings @facebook-github-bot