Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advance rocm to 5.7 and 6.0 in nightly #4939

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jeffdaily
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 9, 2024

@jeffdaily is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pytorch-bot bot commented Feb 9, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2024
@jeffdaily
Copy link
Contributor Author

CC @huydhn @malfet @atalman

@malfet
Copy link
Contributor

malfet commented Feb 9, 2024

@jeffdaily how is it usually tested?

@malfet malfet merged commit d90dee0 into pytorch:main Feb 9, 2024
97 of 103 checks passed
malfet added a commit that referenced this pull request Feb 9, 2024
By updating checked in .json files, regression introduced by me merging
#4939 without realizing it
needed a json update

Regressed by
https://hud.pytorch.org/pytorch/test-infra/commit/d90dee00bf3a2e6a8d349aa7d56311f963b82368
Though to be frank, I'm not sure what's the value of such test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants