Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.12 builds to conda #4835

Closed
wants to merge 1 commit into from
Closed

Add python 3.12 builds to conda #4835

wants to merge 1 commit into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Dec 18, 2023

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2023

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2023
huydhn
huydhn approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A minor thing is to update the expected JSON output of the unit test

@huydhn
Copy link
Contributor

huydhn commented Dec 19, 2023

Closing in favor of #4834

@huydhn huydhn closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @huydhn @malfet @facebook-github-bot