Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override channel priority on installing. Add check for default channel. #4770

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Nov 29, 2023

Forward fix for: #4766

Related to issue: conda/conda-libmamba-solver#398

  1. Make sure packages are searched in particular order during install.
    Use override-channel option when installing packages for smoke test:
    From Conda documentation:
    https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages
From the command line use --c
You may specify multiple channels by passing the argument multiple times.
Priority decreases from left to right - the first argument is higher priority than the second.
From the command line use --override-channels to only search the specified channel(s),
 rather than any channels configured in .condarc.
  1. Add check for validating that required package is actually installed from required channel

Copy link

vercel bot commented Nov 29, 2023

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2023
@atalman atalman changed the title Add check for default channel where package is installed from Override channel priority on installing. Add check for default channel. Nov 29, 2023
Add checkchannel where package is installed

test

test

test

test

test

test

test

test

test

test

test

test

Fix lint

typo
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to add --strict-channel-priority flag, this one one doesn't even need to run 2nd check

-c defaults \
"${PACKAGE_NAME}" \
${CONSTRAINTS} \
--override-channels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--override-channels
--override-channels \
--strict-channel-priority

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Thank you let me try it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like override works better, strict failed to resolve some of the installs:
https://github.com/pytorch/test-infra/actions/runs/7040631634/job/19161895215?pr=4770

@atalman atalman merged commit 6addd63 into pytorch:main Nov 30, 2023
29 of 30 checks passed
@atalman atalman deleted the fix_distr branch November 30, 2023 14:30
atalman added a commit to atalman/test-infra that referenced this pull request Nov 30, 2023
…l. (pytorch#4770)

Forward fix for: pytorch#4766

Related to issue: https://github.com/conda/conda/issues/13374

1. Make sure packages are searched in particular order during install.
Use override-channel option when installing packages for smoke test:
From Conda documentation:

https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages
```
From the command line use --c
You may specify multiple channels by passing the argument multiple times.
Priority decreases from left to right - the first argument is higher priority than the second.
From the command line use --override-channels to only search the specified channel(s),
 rather than any channels configured in .condarc.
```

2. Add check for validating that required package is actually installed
from required channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants