Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.12 to wheel builds #4768

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add python 3.12 to wheel builds #4768

merged 3 commits into from
Dec 1, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Nov 29, 2023 •
edited
Loading

Follow up after pytorch/pytorch#112882.
Please note conda-build and conda is not available yet for Python=3.12. Hence building wheels under Conda Python 3.9.

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2023
malfet
malfet requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why any changes to setup-binary-builds action is necessary? Are you saying that we build both wheels and conda packages for domains using conda dependencies?

@atalman
Copy link
Contributor Author

atalman commented Nov 29, 2023

We used similar code for python 3.11, which was cleaned recently: 3be953c

@atalman atalman mentioned this pull request Nov 30, 2023
Open
@atalman
Copy link
Contributor Author

atalman commented Nov 30, 2023

Why any changes to setup-binary-builds action is necessary? Are you saying that we build both wheels and conda packages for domains using conda dependencies?

Created an issue here: #4773 to get rid of conda env when running wheel builds.

@atalman atalman mentioned this pull request Dec 1, 2023
Merged
malfet
malfet approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman atalman merged commit 32a4ef5 into pytorch:main Dec 1, 2023
231 of 238 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/binaries/all CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @malfet @facebook-github-bot