Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use bash -l {0} for setup-binary-builds initial steps #4338

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jul 3, 2023

Follow up after: #4337
Still observed a failure with retry mechanism:
https://github.com/pytorch/vision/actions/runs/5443957557/jobs/9911563555

Please refer to this comment: #640 (comment)
We want to use bash -l {0} only after the step of conda-incubator/setup-miniconda

@vercel
Copy link

vercel bot commented Jul 3, 2023

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2023
@atalman atalman changed the title Try fixing conda issue Use bash without -l {0] for setup-binary-builds Jul 3, 2023
@atalman atalman changed the title Use bash without -l {0] for setup-binary-builds Use bash without -l {0} for setup-binary-builds initial steps Jul 3, 2023
@atalman atalman changed the title Use bash without -l {0} for setup-binary-builds initial steps Use bash without bash -l {0} for setup-binary-builds initial steps Jul 3, 2023
@atalman atalman changed the title Use bash without bash -l {0} for setup-binary-builds initial steps Don't use bash -l {0} for setup-binary-builds initial steps Jul 3, 2023
@atalman atalman merged commit 3fa5133 into pytorch:main Jul 3, 2023
42 of 58 checks passed
@atalman atalman mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants