Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nightly job for torch.compile benchmarks #2835

Merged
merged 19 commits into from
Dec 9, 2023

Conversation

sachanub
Copy link
Collaborator

@sachanub sachanub commented Dec 7, 2023

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Few points

  1. Where are we installing pytorch nightlies?
  2. I think going forward, we should perhaps only measure BERT with BT. We should show the best possible numbers and not confuse customers.

@sachanub
Copy link
Collaborator Author

sachanub commented Dec 9, 2023

Looks good overall. Few points

  1. Where are we installing pytorch nightlies?
  2. I think going forward, we should perhaps only measure BERT with BT. We should show the best possible numbers and not confuse customers.
  1. The pytorch nightlies are installed via the install_dependencies.py script. I have added an argument in auto_benchmark.py which enables the installation of nightly torch packages via the install_dependencies.py script.
  2. For the scope of this PR, do we want to update the BERT model artifacts?

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Dec 9, 2023
Merged via the queue into master with commit 356704a Dec 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants