Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prims] Unbreak CUDA lazy init #80899

Closed
wants to merge 1 commit into from
Closed

[Prims] Unbreak CUDA lazy init #80899

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jul 5, 2022

CUDA calls should not be made in the default codepath

Fixes #80876

CUDA calls should not be made in the default codepath

Fixes #80876
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 5, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 2247f7f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet requested a review from ngimel July 5, 2022 18:34
@malfet
Copy link
Contributor Author

malfet commented Jul 5, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet malfet deleted the malfet-patch-19 branch July 5, 2022 21:48
@malfet malfet added this to the 1.12.1 milestone Jul 5, 2022
@malfet malfet added release notes: cuda release notes category topic: bug fixes topic category labels Jul 5, 2022
facebook-github-bot pushed a commit that referenced this pull request Jul 6, 2022
Summary:
CUDA calls should not be made in the default codepath

Fixes #80876

Pull Request resolved: #80899
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b62209f047bddbef3c7b7ab822a70d5dd5596165

Reviewed By: mehtanirav

Differential Revision: D37648864

Pulled By: malfet

fbshipit-source-id: 9648e91cdcca96d9f76d873930e4ea2601bfb57d
atalman pushed a commit to atalman/pytorch that referenced this pull request Jul 21, 2022
Summary:
CUDA calls should not be made in the default codepath

Fixes pytorch#80876

Pull Request resolved: pytorch#80899
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b62209f047bddbef3c7b7ab822a70d5dd5596165

Reviewed By: mehtanirav

Differential Revision: D37648864

Pulled By: malfet

fbshipit-source-id: 9648e91cdcca96d9f76d873930e4ea2601bfb57d
atalman added a commit that referenced this pull request Jul 21, 2022
Summary:
CUDA calls should not be made in the default codepath

Fixes #80876

Pull Request resolved: #80899
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b62209f047bddbef3c7b7ab822a70d5dd5596165

Reviewed By: mehtanirav

Differential Revision: D37648864

Pulled By: malfet

fbshipit-source-id: 9648e91cdcca96d9f76d873930e4ea2601bfb57d

Co-authored-by: Nikita Shulga (Meta Employee) <nshulga@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.12] os.environ["CUDA_VISIBLE_DEVICES"] has no effect
4 participants