pack_padded_sequence: Check for empty (zero-element) tensors #21461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: pytorch#20529 Thank you, @JamieCT for the bug report with reproducing script.
apaszke
approved these changes
Jun 6, 2019
apaszke
reviewed
Jun 6, 2019
|
Yes, it comes from the length check accessing the last element. pytorch/aten/src/ATen/native/PackedSequence.cpp Lines 27 to 29 in eb0fea3 Alternatively we could produce packed sequences with 0-element tensors, but I'm not sure that that fits well with the consumers' assumptions. |
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 6, 2019
Summary: Fixes: #20529 Thank you, JamieCT for the bug report with reproducing script. Pull Request resolved: pytorch/pytorch#21461 Differential Revision: D15696183 Pulled By: ezyang fbshipit-source-id: a93cde2c924f8447563c64ce8a1cf75fcee60a01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20529
Thank you, @JamieCT for the bug report with reproducing script.