Fix nll_loss crash on cpu where ignore_index is out of bounds #17328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
reviewed
Feb 21, 2019
| @@ -39,7 +39,7 @@ void THNN_(ClassNLLCriterion_updateOutput)( | |||
| for (i = 0; i < batch_size; i++) { | |||
| int cur_target = THLongTensor_fastGetLegacy1dNoScalars(target, i) - TH_INDEX_BASE; | |||
|
|
|||
| if (cur_target >= 0 && cur_target < n_classes) { | |||
| if ((cur_target >= 0 && cur_target < n_classes) || (cur_target == ignore_index)) { | |||
There was a problem hiding this comment.
Shouldn't it be better if you move the inner if (cur_target == ignore_index) { block outside this?
|
@pytorchbot rebase this please |
|
Sorry, I can't rebase this because the author of this PR didn't grant maintainers permission to modify the branch. Hey @soumith! If you click the Allow edits from maintainers checkbox on the right sidebar, I can rebase PRs automatically from you. Please consider letting me help you out ;) (To learn more about this bot, see Bot commands.) |
ezyang
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 5, 2019
Summary: Fixes pytorch/pytorch#15508 Pull Request resolved: pytorch/pytorch#17328 Differential Revision: D14322629 Pulled By: soumith fbshipit-source-id: 7d02f372be78794782c18affcfc109ce30b1e91c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15508