Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Graph Attention Network example #1174

Merged
merged 17 commits into from
Aug 8, 2023
Merged

Added Graph Attention Network example #1174

merged 17 commits into from
Aug 8, 2023

Conversation

ebrahimpichka
Copy link
Contributor

Hi,

Added Graph Attention Network example. Took the dataset processing procedure from the gcn example with some changes to be consistent with the existing gnn example.
would love to hear feedback.

@netlify
Copy link

netlify bot commented Jul 17, 2023

👷 Deploy Preview for pytorch-examples-preview processing.

Name Link
🔨 Latest commit 9f2446d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/64b5431bd21a580008f6a7aa

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for pytorch-examples-preview failed.

Name Link
🔨 Latest commit 74fdc49
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/64bef893df3ccb0008e3ce2f

@ebrahimpichka
Copy link
Contributor Author

Re #1131

@@ -177,3 +177,14 @@ experiment with PyTorch.
This example implements the `Semi-Supervised Classification with Graph Convolutional Networks <https://arxiv.org/pdf/1609.02907.pdf>`__ paper on the CORA database.

`GO TO EXAMPLE <https://github.com/pytorch/examples/blob/main/gcn>`__ :opticon:`link-external`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc build is failing, most likely culprit is changes to this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I rechecked that.
My local build is served without any issues with sphinx in venv.
i'll keep looking to see where could the issue be

@ebrahimpichka
Copy link
Contributor Author

ebrahimpichka commented Jul 18, 2023

First, it seemed the issue was with the new example card in the doc.
After checking a few times, the build with the default commits (without my changes) once passed ac8d3ef and once failed
d5fe1d2 the checks.

Couldn't find the issue with the build since it builds locally with no issues.

@msaroufim
Copy link
Member

@sekyondaMeta @svekars any idea what's going on with the doc build here?

@sekyondaMeta
Copy link

@sekyondaMeta @svekars any idea what's going on with the doc build here?

I wonder if this failure here is the culprit:
https://github.com/pytorch/examples/actions/runs/5627940947/job/15251219562?pr=1174

One of the changes added numpy 1.25.1 and there is probably a requirement somewhere else for 1.24.2

@ebrahimpichka
Copy link
Contributor Author

@sekyondaMeta thanks, removed the version specification from the requirements file

@msaroufim
Copy link
Member

@svekars could I please get access to the netlify logs? I can't see why this is failing

@msaroufim msaroufim merged commit 4440841 into pytorch:main Aug 8, 2023
2 of 6 checks passed
@ebrahimpichka
Copy link
Contributor Author

Thanks @msaroufim
I did not add the doc card for the example.
should I add it in another PR or it's not required?

@msaroufim
Copy link
Member

Make a separate PR. I'm still not sure what's going on with docbuikd since I can't read the build failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants