-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable model_id for TCAV #811
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D32815352 |
NarineK
added a commit
to NarineK/captum-1
that referenced
this pull request
Dec 4, 2021
Summary: Pull Request resolved: pytorch#811 1. Added model_id to TCAV and removed hard coded: DEFAULT_MODEL_ID. 2. Saves cavs in a model_id subfolder instead of the generic CAVs directory. 3. Created CAV related subfolders in advance before generating cavs in single or multi-processing setup. 4. Added test case for model_id 5. Removed av.py in concepts package since we are now using av.py from utils 6. Add captum logging to TCAV Reviewed By: bilalsal Differential Revision: D32815352 fbshipit-source-id: 5bed7377bb974459e926726305de40d8e1d58ee1
This pull request was exported from Phabricator. Differential Revision: D32815352 |
98f98b9
to
58a7f7a
Compare
NarineK
added a commit
to NarineK/captum-1
that referenced
this pull request
Dec 4, 2021
Summary: Pull Request resolved: pytorch#811 1. Added model_id to TCAV and removed hard coded: DEFAULT_MODEL_ID. 2. Saves cavs in a model_id subfolder instead of the generic CAVs directory. 3. Created CAV related subfolders in advance before generating cavs in single or multi-processing setup. 4. Added test case for model_id 5. Removed av.py in concepts package since we are now using av.py from utils 6. Add captum logging to TCAV Reviewed By: bilalsal Differential Revision: D32815352 fbshipit-source-id: 15222ddf429347a929a57d6b073db970b68796bf
This pull request was exported from Phabricator. Differential Revision: D32815352 |
58a7f7a
to
bcfd2a8
Compare
Summary: Pull Request resolved: pytorch#811 1. Added model_id to TCAV and removed hard coded: DEFAULT_MODEL_ID. 2. Saves cavs in a model_id subfolder instead of the generic CAVs directory. 3. Created CAV related subfolders in advance before generating cavs in single or multi-processing setup. 4. Added test case for model_id 5. Removed av.py in concepts package since we are now using av.py from utils 6. Add captum logging to TCAV Reviewed By: bilalsal Differential Revision: D32815352 fbshipit-source-id: 1571b7a0535bd1a3d31e14cd5cb4c84d56bb041d
bcfd2a8
to
6181fe6
Compare
This pull request was exported from Phabricator. Differential Revision: D32815352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D32815352