change TCAV to use captum/_utils/fb/av.py #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99warriors
force-pushed
the
export-D30566560
branch
2 times, most recently
from
06ee973
to
100136c
Compare
99warriors
force-pushed
the
export-D30566560
branch
from
100136c
to
b172fff
Compare
|
@99warriors, it looks like some of the tests and linter failed. Do you mind looking into them ? |
99warriors
force-pushed
the
export-D30566560
branch
16 times, most recently
from
7984112
to
3634f8d
Compare
99warriors
force-pushed
the
export-D30566560
branch
7 times, most recently
from
dfb8233
to
cfb2d85
Compare
Summary: AV.load now returns a Dataset, not a DataLoader Also, activations for a single layer and multiple concepts are no longer stored as a single DataLoader (which also generates labels). Instead, they are stored as a list of Datasets (not DataLoaders). This list is used to create a Dataset (not DataLoader) that also generates labels. I think it is better to pass around Datasets for as long as possible, because they are more flexible. Reviewed By: NarineK Differential Revision: D30566560 fbshipit-source-id: ce78151cf94dac2bfb51f34add1bc51dd0369887
99warriors
force-pushed
the
export-D30566560
branch
from
cfb2d85
to
86a12c5
Compare
|
Closing since the changes have been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AV.load now returns a Dataset, not a DataLoader
Also, activations for a single layer and multiple concepts are no longer stored as a single DataLoader (which also generates labels). Instead, they are stored as a list of Datasets (not DataLoaders). This list is used to create a Dataset (not DataLoader) that also generates labels. I think it is better to pass around Datasets for as long as possible, because they are more flexible.
Differential Revision: D30566560