Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseFeature, ImageFeature, TextFeature, GeneralFeature in the in __init__.py #565

Closed
wants to merge 1 commit into from

Conversation

limberc
Copy link

@limberc limberc commented Dec 20, 2020

Currently, in tutorial here, the command: from captum.insights.features import ImageFeature, TextFeature can not be loaded.

I have added the Features in the init module. It works great.

@facebook-github-bot
Copy link
Contributor

Hi @limberc!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@NarineK
Copy link
Contributor

NarineK commented Dec 21, 2020

cc: @edward-io, @Reubend

@edward-io
Copy link
Contributor

Thanks for the PR. #556 will fix the import issue by importing the features fromcaptum.insights.attr_vis instead

@edward-io edward-io closed this Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants