Reduced Captum Insights package size #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vivekmig
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: This commit reduces the size of Captum Insights by - Replacing the old graphing library with a more lightweight one - In the standalone app, using compression in the Flask server - In the notebook extension, excluding unused dependencies-of-dependencies  For the standalone app, it reduces the size significantly:  For the notebook extension, there's a similar size reduction of `index.js` from 1090 KB to 449 KB. Testing: I used `titanic.py` to test this change, making sure that the graphs are working as before and that the other functionality is unnafected. Pull Request resolved: #562 Reviewed By: edward-io Differential Revision: D25628623 Pulled By: Reubend fbshipit-source-id: ef8a0d9ec8c7e0df6955b69dd7a96656defc37e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the size of Captum Insights by
For the standalone app, it reduces the size significantly:
For the notebook extension, there's a similar size reduction of
index.jsfrom 1090 KB to 449 KB.Testing: I used
titanic.pyto test this change, making sure that the graphs are working as before and that the other functionality is unnafected.