Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to compare multiple models in Captum Insights #551

Closed
wants to merge 1 commit into from

Conversation

Reubend
Copy link
Contributor

@Reubend Reubend commented Dec 7, 2020

This PR adds the ability to compare multiple models in Captum Insights.

Screenshot of model comparison

In order to test this, I went through two scenarios. First, I made sure there are no regressions to single model workflows like this:

  1. Start the Insights example with python3 -m captum.insights.example
  2. Ensure that the original functionality is still working and there are no changes, other than the visual changes for column headers

Then, I tested comparing multiple models by duplicating the existing example one:

  1. Go to example.py
  2. Duplicate the example model, by changing models=[model] to models=[model, model, model]
  3. Check to make sure that it renders properly, and that selecting different target classes works to properly update the data for each visualization

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@edward-io edward-io self-requested a review December 8, 2020 23:40
Copy link
Contributor

@edward-io edward-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@facebook-github-bot
Copy link
Contributor

@Reubend merged this pull request in e4520f3.

vivekmig pushed a commit that referenced this pull request Jan 21, 2021
Summary:
This PR adds the ability to compare multiple models in Captum Insights.

![Screenshot of model comparison](https://user-images.githubusercontent.com/13208038/101406612-869ed600-388e-11eb-9520-62797a9ae3db.png)

In order to test this, I went through two scenarios. First, I made sure there are no regressions to single model workflows like this:
1. Start the Insights example with `python3 -m captum.insights.example`
2. Ensure that the original functionality is still working and there are no changes, other than the visual changes for column headers

Then, I tested comparing multiple models by duplicating the existing example one:

1. Go to `example.py`
2. Duplicate the example model, by changing `models=[model]` to `models=[model, model, model]`
3. Check to make sure that it renders properly, and that selecting different target classes works to properly update the data for each visualization

Pull Request resolved: #551

Reviewed By: edward-io

Differential Revision: D25379744

Pulled By: Reubend

fbshipit-source-id: 4999c1ef0f18b8f735cd47a890cef413a7c6548e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants