Ablation Device Fix #528
Closed
Ablation Device Fix #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Allows output to be on a different device than input by moving output difference to input device. Differential Revision: D25001273 fbshipit-source-id: b167412fc45e513c98f61ea640e06268c44eec30
|
This pull request was exported from Phabricator. Differential Revision: D25001273 |
NarineK
approved these changes
Nov 20, 2020
| @@ -348,7 +348,7 @@ def attribute( | |||
| ).reshape((-1, num_outputs) + (len(inputs[i].shape) - 1) * (1,)) | |||
| if self.use_weights: | |||
| weights[i] += current_mask.float().sum(dim=0) | |||
| total_attrib[i] += (eval_diff * current_mask.to(attrib_type)).sum( | |||
| total_attrib[i] += (eval_diff.to(total_attrib[i].device) * current_mask.to(attrib_type)).sum( | |||
There was a problem hiding this comment.
looks like there is a flake8 issue.
|
This pull request has been merged in 50167ad. |
vivekmig
added a commit
that referenced
this pull request
Jan 21, 2021
Summary: Pull Request resolved: #528 Allows output to be on a different device than input by moving output difference to input device. Reviewed By: miguelmartin75 Differential Revision: D25001273 fbshipit-source-id: a9b6d8e8bb585d5360c53272a5502f4e8f257459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allows output to be on a different device than input by moving output difference to input device.
Differential Revision: D25001273