Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Visualization Normalization #458

Closed
wants to merge 2 commits into from

Conversation

vivekmig
Copy link
Contributor

Addresses issue #393 , continue scaling attributions with small magnitude with a warning, only asserting when scale factor is 0.

@vivekmig vivekmig requested a review from NarineK August 25, 2020 20:22
Copy link
Contributor

@NarineK NarineK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vivekmig merged this pull request in 4781476.

NarineK pushed a commit to NarineK/captum-1 that referenced this pull request Nov 19, 2020
Summary:
Addresses issue pytorch#393 , continue scaling attributions with small magnitude with a warning, only asserting when scale factor is 0.

Pull Request resolved: pytorch#458

Reviewed By: bilalsal

Differential Revision: D23347489

Pulled By: vivekmig

fbshipit-source-id: 816a0ca98119a4fe7726325fcbd63dd0ce21f3c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants