Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Layer Support #456

Closed
wants to merge 10 commits into from
Closed

Conversation

vivekmig
Copy link
Contributor

This adds support to obtain attributions for multiple layer for LayerActivation and LayerGradientXActivation with corresponding changes to helper methods to support multiple layers. Also adds appropriate DataParallel tests and updates documentation.

@vivekmig vivekmig requested a review from NarineK August 25, 2020 20:22
Copy link
Contributor

@NarineK NarineK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for working on this PR.
Minor comments related to torch.nn.Sequential and documentation.

captum/attr/_core/layer/layer_activation.py Show resolved Hide resolved
captum/_utils/typing.py Show resolved Hide resolved
captum/attr/_core/layer/layer_gradient_x_activation.py Outdated Show resolved Hide resolved
captum/attr/_core/layer/layer_conductance.py Show resolved Hide resolved
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vivekmig merged this pull request in 87e5614.

NarineK pushed a commit to NarineK/captum-1 that referenced this pull request Nov 19, 2020
Summary:
This adds support to obtain attributions for multiple layer for LayerActivation and LayerGradientXActivation with corresponding changes to helper methods to support multiple layers. Also adds appropriate DataParallel tests and updates documentation.

Pull Request resolved: pytorch#456

Reviewed By: NarineK

Differential Revision: D23741638

Pulled By: vivekmig

fbshipit-source-id: 2b6a4d01de8a1ddc838482637b2bcef0a0f62515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants