-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Occlusion to Insights #369
Conversation
edward-io
commented
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
93a0b67
to
837a5cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there's just one question I had.
"sliding_window_shapes": StrConfig(value=""), | ||
"strides": StrConfig(value=""), | ||
}, | ||
post_process={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these post-processing steps necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Occlusion takes in a tuple or an int e.g. (3, 5, 5)
, so we need a way to convert a string representation into the appropriate format.
e733e7e
to
47499a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
47499a9
to
545beea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Add fix to UI config parsing |
Summary: Seeing this unrelated error in #369: https://circleci.com/gh/pytorch/captum/6777?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link. Pull Request resolved: #379 Reviewed By: bilalsal Differential Revision: D21514229 Pulled By: edward-io fbshipit-source-id: 6a8f89807b7a9b930fcbfa2d3fe4332d91e3e5a8
3cd741c
to
3fb83ad
Compare
3fb83ad
to
d0a8800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
add perturbations_per_eval as a config option to occlusion |
@edward-io merged this pull request in c2062db. |
Summary: Seeing this unrelated error in pytorch#369: https://circleci.com/gh/pytorch/captum/6777?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link. Pull Request resolved: pytorch#379 Reviewed By: bilalsal Differential Revision: D21514229 Pulled By: edward-io fbshipit-source-id: 6a8f89807b7a9b930fcbfa2d3fe4332d91e3e5a8
Summary: ![image](https://user-images.githubusercontent.com/53842584/81026858-6efefb00-8e30-11ea-970d-5c6907fe3e7b.png) Pull Request resolved: pytorch#369 Reviewed By: vivekmig, J0Nreynolds Differential Revision: D21394665 Pulled By: edward-io fbshipit-source-id: 4f6848928fa271b99ee8a376b6232985fc739b2c