Hook Removal #340
Closed
Hook Removal #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NarineK Updated this PR, it should be ready for review now, thanks! |
NarineK
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Looks great! Thank you! Couple suggestions.
- We could use try-finally and remove the hooks in the finally block once and avoid second remove for the normal case and except-raise-error blocks.
- It looks like here we might also need a try-finally block ?
https://github.com/pytorch/captum/blob/master/captum/attr/_utils/gradient.py#L240
| read the documentation in test_config.py and add cases based on the | ||
| schema described there. | ||
| """ | ||
|
|
There was a problem hiding this comment.
We probably also need to do try-finally for this one ?
https://github.com/pytorch/captum/blob/master/captum/attr/_utils/gradient.py#L240
There was a problem hiding this comment.
I think this line is already updated above? But will switch from except to finally.
There was a problem hiding this comment.
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for the review!
|
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: This PR ensures that all hooks are removed, even if attribution raises an error while the hook is placed. Corresponding generated tests are also added, which simulate errors during runtime and verify that no hooks remain on the model after execution. Note that this PR depends on the generated tests, so code is included here as well, will resolve this once the updated tests PR is merged. Pull Request resolved: pytorch#340 Reviewed By: edward-io Differential Revision: D21020096 Pulled By: vivekmig fbshipit-source-id: 05efaf9021222318d3adf2b029592754d7c836e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all hooks are removed, even if attribution raises an error while the hook is placed. Corresponding generated tests are also added, which simulate errors during runtime and verify that no hooks remain on the model after execution.
Note that this PR depends on the generated tests, so code is included here as well, will resolve this once the updated tests PR is merged.